test(c-tool-calls): assert on chat-tool-calls + chat-tool-call-card primitives directly#497
Merged
Conversation
…rimitives directly
Tightens the existing tool-call UI assertion from a generic
getByRole('button', { name: /lookup_flight|tool/i }) (which would match
any unrelated button on the page) to the specific @ngaf/chat custom-element
selectors:
- <chat-tool-calls> visible (proves the wrapper primitive mounted).
- <chat-tool-call-card> visible + contains 'lookup_flight' (proves the
per-call card rendered with the right tool name).
Same end-to-end coverage; more specific surface area means less false-pass
risk if the demo template ever adds an unrelated button on the page.
Also switches the final-bubble text assertion from innerText().toLowerCase()
to Playwright's built-in toContainText({ ignoreCase: true }) — auto-retries
on the locator instead of one-shot.
Identified during the post-Task-#4 e2e audit (item #10).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the existing tool-call UI assertion in `c-tool-calls.spec.ts` from a generic `getByRole('button', { name: /lookup_flight|tool/i })` to the specific `@ngaf/chat` custom-element selectors.
Before vs after
Before: `getByRole('button', { name: /lookup_flight|tool/i }).first()` — matches any button containing those substrings, including unrelated UI like settings menus.
After: Three layered assertions on the actual primitives:
Same end-to-end behavior covered; reduced false-pass risk if the demo template ever adds an unrelated button somewhere on the page.
Also switches the final-bubble text assertion from `innerText().toLowerCase()` + `expect.toContain()` to Playwright's built-in `toContainText({ ignoreCase: true })` which auto-retries on the locator.
Identified during
Post-Task-#4 e2e audit (item #10).
Test plan
🤖 Generated with Claude Code